Storyshots: framework option should override package dependency check #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
- Coverage 14.6% 14.54% -0.07%
==========================================
Files 202 202
Lines 4655 4649 -6
Branches 508 515 +7
==========================================
- Hits 680 676 -4
+ Misses 3533 3522 -11
- Partials 442 451 +9
Continue to review full report at Codecov.
|
tmeasday
requested changes
Jul 22, 2017
| @@ -24,6 +24,7 @@ | |||
| "@storybook/channels": "file:../../lib/channels", | |||
| "@storybook/channel-postmessage": "file:../../lib/channel-postmessage", | |||
| "@storybook/react-native": "file:../../app/react-native", | |||
| "@storybook/react": "file:../../app/react", | |||
There was a problem hiding this comment.
Are you just adding this line to prove that the fix works, or does it make sense to have it for the RNV app?
There was a problem hiding this comment.
Ok can we drop it then? Thanks!
There was a problem hiding this comment.
Sounds like this will be super easy to clear up and merge?
|
Done, Thanks @ktj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
elderfo/react-native-storybook-loader#26
What I did
In storyshots addon I modified the framework check to make sure framework option overrides dependency check.
How to test
Reproduction project: https://github.com/ktj/storyshots-rp
-> tests fail
remove line 8 form package json -> tests work
I've added 3.1.9 example with latest react-native:
https://github.com/ktj/storyshots-rp/tree/319
I added storyshots with this fix as dependency.